RAFS V6 update #242
Merged
RAFS V6 update #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 58be14a ("storage: fix data corruption when blob's ci compressor is none") fixed a bug which can be reproduced by this unit test. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
BlobMetaState has a 'chunks' which borrows memory from the mmaped
range over the "${blob_id}.blob.meta" file, since it's created with
ManuallyDrop, we need to munmap explicitly.
Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
It's possible that self.s_meta_blkaddr == 0 and self.s_xattr_blkaddr != 0 for shared xattr use as RAFS v6 images. Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
If per-file timestamp is no needed, 32-byte inodes can be used instead as long as the file sizes are smaller than 4GiB and has 16-bit uid, gid. Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
By design, uuid and blob_id in the same union. uuid is not directly used by RAFS v6. Drop it instead. Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
The encoded sha256 has been used as blobid to locate blob cache files, this fixes the 32 bytes blobid in RafsV6Device so that we can find the correct blob files. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Nydus v6 needs "aligned chunk" to make sure kernel fs can read blob cache files correctly. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Commit b434a3e ("Storage/meta: add munmap for mmaped range") introduced the regression. Since the name is quite confusing, this is to clarify it a little bit, BlobMetaState's [un]compressed_size is used by get_chunk_[un]compressed() and is considered as file length of a blob, NOT a blob's ondisk chunk info's size. Given the above, we are not able to get correct unmap length from uncompressed_size, this adds a 'unmap_len' for Drop. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Since it's synchronous, the caller needs to be aware of the error if any. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patchset addresses v6 implementation regression.
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>