storage: refactor file cache code for coming fscache #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move code to manage cached file object from filecache/cache_entry.rs into cachedfile.rs, so it could shared by fscache subsystem later. Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
Refine file cache related code by: 1) merge cache_entry.rs into filecache/mod.rs 2) rename BlobCacheConfig to FileCacheConfig Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
Share a global async runtime instance instead of a runtime per cache manager. Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
jiangliu
requested review from
changweige,
bergwolf,
imeoer,
hsiangkao and
xujihui1985
and removed request for
bergwolf
|
looks good |
liubogithub
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code to manage cached file object from filecache/cache_entry.rs
into cachedfile.rs, so it could shared by fscache subsystem later.
Signed-off-by: Liu Jiang gerry@linux.alibaba.com