Builder: make repeatable for root directory #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually the root directory is created by the build tool (nydusify/buildkit/acceld) and the mtime of the root directory is different for each build, which makes it completely impossible to achieve repeatable builds, especially in a tar build scenario (blob + bootstrap in one tar layer), which causes the layer hash to change and wastes registry storage space, so the mtime of the root directory is forced to be ignored. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
jiangliu
approved these changes
Apr 6, 2022
bergwolf
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the root directory is created by the build tool (nydusify/buildkit/acceld)
and the mtime of the root directory is different for each build, which makes it
completely impossible to achieve repeatable builds, especially in a tar build scenario
(blob + bootstrap in one tar layer), which causes the layer hash to change and wastes
registry storage space, so the mtime of the root directory is forced to be ignored.
Signed-off-by: Yan Song imeoer@linux.alibaba.com