builder: fix lost hardlink #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubogithub
reviewed
Apr 29, 2022
liubogithub
reviewed
Apr 29, 2022
@liubogithub Will add a test case to the converter package since |
@liubogithub Not true, For example, if there is a hardlink pair |
bergwolf
reviewed
May 5, 2022
imeoer
force-pushed
the
builder-fix-lost-hardlink
branch
from
a7d8545
to
109fc72
Compare
The merge operation in builder (nydus-image) use `RafsSuper::walk_inodes` method to walkthrough the whole filesystem inodes by DFS order, but it does not call the callback for the hardlink pair, which causes some hardlink files to be lost in the final bootstrap after merge. The root cause is that the `RafsSuper::get_inode` method always gets only the RafsInode of a particular file name in the hardlink pair because the ino numbers of the hardlink pair are the same. Fix by passing `RafsInode` trait object in `RafsSuper::walk_inodes` directly. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
builder-fix-lost-hardlink
branch
from
109fc72
to
ad778db
Compare
bergwolf
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge operation in builder (nydus-image) use
RafsSuper::walk_inodesmethod to walkthrough the whole filesystem inodes by DFS order, but it
does not call the callback for the hardlink pair, which causes some hardlink
files to be lost in the final bootstrap after merge.
The root cause is that the
RafsSuper::get_inodemethod always gets onlythe RafsInode of a particular file name in the hardlink pair because the ino
number of the hardlink pair are the same.
Fix by passing
RafsInodetrait object inRafsSuper::walk_inodesdirectly.Signed-off-by: Yan Song imeoer@linux.alibaba.com