Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: release macos bianries as well #429

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

bergwolf
Copy link
Member

@bergwolf bergwolf commented May 13, 2022

Right now, only nydusctl and nydusd compile on macos. So just include
them in the release tarball. Other binaries can be included later.

Example run can be found here: https://github.com/bergwolf/image-service/runs/6420841588

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Right now, only nydusctl and nydusd compile on macos. So just include
them in the release tarball. Other binaries can be included later.

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 81c4189 into dragonflyoss:master May 13, 2022
@adamqqqplay adamqqqplay removed the wip label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants