Improvements to the blob cache manager #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine blob cache manager code by: 1) add more doc 2) refine error messages 3) add const ID_SPLITTER Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
jiangliu
force-pushed
the
blobcache
branch
11 times, most recently
from
4aceb02 to
38ef97a
Compare
Change id splitter for domain id and blob id from "-" to "/" and ensure that domain/blob id doesn't contain the splitter char. This helps to protect malicious user to access blobs in other domain by tweaking the blob id. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Add unit test case to insert bootstrap blob into blob cache manager. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
jiangliu
force-pushed
the
blobcache
branch
11 times, most recently
from
b013c82 to
8faf701
Compare
The currently API only supports removing all blobs associated with a domain, so enhance the API to support removing specific blob too. Also rename BlobObjectParam to BlobCacheObjectId. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
jiangliu
force-pushed
the
blobcache
branch
3 times, most recently
from
ccfb40c to
59a92cd
Compare
jiangliu
force-pushed
the
blobcache
branch
4 times, most recently
from
cb3ddd2 to
772cc3e
Compare
jiangliu
changed the title
imeoer
reviewed
Jun 6, 2022
|
Others LGTM! |
|
@nan1994 please help test this with the latest fscache kernel, thanks! |
Currently implementation doesn't support sharing data blobs among bootstraps/container images. So enhance the implementation to support data blob sharing. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
|
I have tested this with the latest fscache kernel and it works well. |
hsiangkao
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the nydusd blob cache manager.