Introduce async framework and clean up prefetch related logic #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
hsiangkao,
imeoer,
changweige and
luodw
and removed request for
hsiangkao
jiangliu
changed the title
jiangliu
force-pushed
the
prefetch
branch
3 times, most recently
from
af281a1 to
443baae
Compare
Currently AsyncWorkerMgr is implemented by using synchronous multi-threading, which has some limitations. So let's build async framework for AsyncWorkerMgr by: 1) Implement unbound multi-producer multi-consumer (mpmc) channel by using tokio::sync::Notify 2) Use tokio current thread Runtime instead of the default multi-threaded Runtime. This will help to support io-uring in future. 3) Use work-stealing mode to dispatch tasks. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Rename AsyncRequestState to AsyncPrefetchState. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Move network bandwidth rate limiter from AsyncWorkerMgr::send() to AsyncWorkerMgr::run(). Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Add test case for network bandwidth rate limiter. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
1) group current function as prefetch related 2) centralize rate limit for prefetch requests 3) prepare to support other non-prefetch request messages Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Syntax only refinements to fscache, there should be no functional changes. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
liubogithub
reviewed
Jun 9, 2022
Currently we have enabled the async runtime framework, but most internal implementation is still in sync mode. |
The data prefetch related code has been refactored several times, and it becomes a little complex. So go over code again to remove some legacy code. The most important change is to use reference count to track prefetch status instead of an on/off flag. It gets messy with the on/off flag when dealing with blob sharing/reuse. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Add a picture for data prefetch architure. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Flush pending prefetch requests when closing fscache fd, otherwise the blob gc will be blocked. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
imeoer
reviewed
Jun 9, 2022
liubogithub
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to build an async framework for storage/worker by using tokio Notify and current thread runtime.
Also clean up data prefetch related logic, those are left over from legacy code.