Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nydusify & nydus-image: v6 image conversion support #473

Merged
merged 21 commits into from
Jun 10, 2022
Merged

nydusify & nydus-image: v6 image conversion support #473

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d6e0a95
nydus-image: bug fix for `dirents_offset` overflow for non-dir/non-sy…
yawqi Jun 2, 2022
282cd91
nydus-image: feature, begin adding support for v6 image multi layer b…
yawqi Jun 2, 2022
c0f6d41
nydus-image: feature, implement interfaces for v6 OndiskInodeWrapper
yawqi Jun 2, 2022
9228759
nydus-image: feature, v6 multi layer build suppot
yawqi Jun 2, 2022
1244ac6
nydus-image: bug fix, correct implementation of chunk info for v6
zyfjeff Jun 6, 2022
4a0a6d2
nydus-image: bug fix, fix . and .. 's incorrent dirent order
zyfjeff Jun 6, 2022
449303a
nydus-image: bug fix, fix invalid xatttr size
zyfjeff Jun 7, 2022
448cf2b
nydusify: support nydus v6 image build
zyfjeff Jun 6, 2022
e87929f
nydus-image: enable image validate for v6
zyfjeff Jun 7, 2022
8779711
nydus-image: enable rafsv6 smoke test
zyfjeff Jun 7, 2022
90fc1ab
test: disable digest validate for v6
zyfjeff Jun 7, 2022
e57f42d
nydusify: support v6 image build test
zyfjeff Jun 7, 2022
dc1fdcc
nydusify: disable digest validate and use direct mode for v6
zyfjeff Jun 7, 2022
c58ef29
nydusify: rename `image_version` to `fs-version` to be consistent wit…
yawqi Jun 8, 2022
e0c085b
test: fix wrong spelling
zyfjeff Jun 8, 2022
9d991f8
test: safe to stop registry container
zyfjeff Jun 8, 2022
712bd1d
nydus-image: partial implementation inspect subcommand for v6
zyfjeff Jun 8, 2022
2fca2db
Fix code review comments
zyfjeff Jun 8, 2022
8da4bd3
nydusify: change fs-image args usage describe
zyfjeff Jun 8, 2022
e033493
Use native rust way replace if-self
zyfjeff Jun 9, 2022
5bb773d
Handle borrow_mut panic
zyfjeff Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/smoke.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ fn test(
cache_compressed,
rafs_mode.parse().unwrap(),
"api.sock".into(),
true,
!rafsv6,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please leave a comment either here or in the patch log for why digest validate for v6 is disabled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually already has some comments. exists only where it was first used.

            // FIXME: Currently no digest validation is implemented for rafs v6.
            !rafsv6,

);
nydusd.start(Some("bootstrap-overlay"), "mnt");
nydusd.check(&overlay_texture, "mnt");
Expand All @@ -124,7 +124,7 @@ fn test(
cache_compressed,
rafs_mode.parse().unwrap(),
"api.sock".into(),
true,
!rafsv6,
);
nydusd.start(Some("bootstrap-overlay"), "mnt");
nydusd.check(&overlay_texture, "mnt");
Expand Down