comments: modify comments of src_ino and i_ino #519
Conversation
rafs/src/metadata/layout/v5.rs
Outdated
| @@ -914,7 +914,7 @@ pub struct RafsV5Inode { | |||
| pub i_digest: RafsDigest, // 32 | |||
| /// parent inode number | |||
| pub i_parent: u64, | |||
| /// from fs stat() | |||
| /// rafs inode number, set_ino() from RAFS_ROOT_INODE = 1 | |||
There was a problem hiding this comment.
The comment is a little confusing, could you help to elaberate more?
There was a problem hiding this comment.
src_ino is rafs inode number, but not from fs stat().
src_ino is set by function set_ino(), and its number is from const RAFS_ROOT_INODE = 1.
There was a problem hiding this comment.
I think for the "/" inode, it's set to RAFS_ROOT_INODE. For other inodes, it should be read from fs by stat().
If so, it would be better to just remove the comments.
power-more
force-pushed
the
zhaoshang/comments
branch
from
3afe1f9 to
95deaca
Compare
|
@power-more , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
|
@power-more , the test job has been submitted. Please wait in patience. |
|
@power-more , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
rafs/src/metadata/layout/v5.rs
Outdated
| @@ -914,7 +914,7 @@ pub struct RafsV5Inode { | |||
| pub i_digest: RafsDigest, // 32 | |||
| /// parent inode number | |||
| pub i_parent: u64, | |||
| /// from fs stat() | |||
| /// rafs inode number, set from 1 | |||
There was a problem hiding this comment.
How about:
/// Artifact inode number set by the nydus image builder. Start from RAFS_ROOT_INODE = 1.
Signed-off-by: zhaoshang <zhaoshangsjtu@linux.alibaba.com>
power-more
force-pushed
the
zhaoshang/comments
branch
from
95deaca to
68f3161
Compare
|
@power-more , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
|
@power-more , your test job has passed, and no need to test again. |
Signed-off-by: zhaoshang zhaoshangsjtu@linux.alibaba.com