Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: add integration tests for nydus #535

Merged
merged 8 commits into from
Jun 28, 2022

Conversation

yawqi
Copy link
Contributor

@yawqi yawqi commented Jun 26, 2022

Currently, we only run 4 tests in test_api.py, due to timeout and some undetermined errors.

@yqleng1987
Copy link
Contributor

@yawqi , a new test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

@yawqi yawqi changed the title WIP github actions: add integration tests for nydus github actions: add integration tests for nydus Jun 27, 2022
@yqleng1987
Copy link
Contributor

@yawqi , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , your test job has passed, and no need to test again.


from utils import read_images_array

REGISTRY_ADDR = "https://docker.alibaba-inc.com/#/imageList"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test file aims at testing internal business system container images. Besides a list of private/internal images, it is quite similar to other test cases. So I think we might drop the test file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks a lot! ; )

@yqleng1987
Copy link
Contributor

@yawqi , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , the test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

liubogithub and others added 7 commits June 28, 2022 09:21
This integration tests covers nydusd and nydus-image as well as
nydusify, nydus-snapshotter.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Instead of hardcoding the path of ossutil binary, this allows the
tests to read binary path from the anchor file.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
test_backend_swap failed for some unknown reasons, skip it for now.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
This adds a new action to run nydus integration test.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
This runs only test_api for now to avoid timeout issue.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
For now, to avoid timeout and unknown error reasons,
we temporarily only runs 4 tests in test_api.py,
other tests still need to be tested.

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
The use of cross-0.2.2 leads to constantly
cancelled CI, therefore we downgrade it.

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
@yqleng1987
Copy link
Contributor

@yawqi , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , your test job has passed, and no need to test again.

The secret in github actions won't be passed to
actions triggered by pull request. What's more,
the time consumed is unacceptable. Therefore,
we change integration test to nightly test.

Signed-off-by: Qi Wang <wangqi@linux.alibaba.com>
@yqleng1987
Copy link
Contributor

@yawqi , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , the test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yawqi , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

@liubogithub liubogithub merged commit 7b0b981 into dragonflyoss:master Jun 28, 2022
"registry_auth": "Y2h1YW5sYW5nLmdjdzoxcWF6MndzeA=="
},
"oss": {
"endpoint": "oss-cn-beijing.aliyuncs.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only skopeo and stargzify binaries stored in framework/bin now which are being committed within this PR. Could we also store them into the OSS bucket? We can improve the test framework to make it try to download from a OSS bucket. Otherwise, changes to the binaries make nydus repo bigger and bigger.
Actually, I can take this task to improve the frame work to avoid store many binaries in the code repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants