fscache: enable multi-threading to process fscache requests #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiangliu , a new test job has been submitted. Please wait in patience. |
Add command line option "fscache-threads" to nydusd to support multi-threading for fscache service. There's one thread to receive fscache request from cachefile fd, and dispatch `READ` requests to multiple working threads through a multi-producer, multi-consumer channel. We have observed about 40% performance boost when serving some multi threading container workloads. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
|
@jiangliu , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
|
@jiangliu , the test job has been submitted. Please wait in patience. |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
LGTM, |
imeoer
reviewed
Jun 27, 2022
| @@ -117,16 +120,33 @@ impl ServiceController { | |||
| }; | |||
| let tag = subargs.value_of("fscache-tag"); | |||
|
|
|||
| let mut threads = 1usize; | |||
| if let Some(threads_value) = subargs.value_of("fscache-threads") { | |||
| if let Ok(t) = threads_value.parse::<i32>() { | |||
There was a problem hiding this comment.
Perhaps we can reuse the validator code above.
There was a problem hiding this comment.
Could you please help to give more hints about the way to reuse code? I haven't found similar pieces of code yet.
There was a problem hiding this comment.
I think it is like this :)
imeoer
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command line option "fscache-threads" to nydusd to support
multi-threading for fscache service. There's one thread to receive
fscache request from cachefile fd, and dispatch
READrequests tomultiple working threads through a multi-producer, multi-consumer
channel.
We have observed about 40% performance boost when serving some multi
threading container workloads.
Signed-off-by: Jiang Liu gerry@linux.alibaba.com