fscache: fix large stargz chunks processing #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested OK with fscache backend and ghcr.io/stargz-containers/wordpress:5.9.2-esgz ! |
imeoer
force-pushed
the
fix-stargz-large-chunk
branch
from
88f0e43
to
0fe072a
Compare
Ensure that the stargz chunks in the blob meta are sorted by uncompressed_offset and ordered by chunk index so that they can be found quickly at runtime with a binary search. Signed-off-by: Yan Song <yansong.ys@antfin.com>
|
@imeoer , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
|
@imeoer , the test job has been submitted. Please wait in patience. |
1. use blob_compressed_size to compute stargz's compressed gzip_size; 2. use binary search to find stargz chunk (sorted by uncompressed_offset in blob meta); Signed-off-by: Yan Song <yansong.ys@antfin.com>
imeoer
force-pushed
the
fix-stargz-large-chunk
branch
from
0fe072a
to
87fdc00
Compare
|
@imeoer , your pull request has been updated, but no change is detected in the code. |
imeoer
changed the title
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@imeoer can we highlight this feature in |
hsiangkao
approved these changes
Jul 2, 2022
I think they can be in another PR, let's fix the break first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder: sort stargz chunks by uncompressed_offset
fscache: some fixups for large stargz chunk
Signed-off-by: Yan Song yansong.ys@antfin.com