Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency #738

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Reduce dependency #738

merged 4 commits into from
Sep 23, 2022

Conversation

jiangliu
Copy link
Collaborator

@jiangliu jiangliu commented Sep 21, 2022

Before reduction:
root@0bba89291a46:/nydus# cargo build --features=fusedev
Compiling nydus-app v0.3.0 (/nydus/app)
Compiling nydus-api v0.1.1 (/nydus/api)
Compiling nydus-storage v0.5.0 (/nydus/storage)
^C Building [=======================> ] 264/274: nydus-app(build.rs), nydus-api, nydus-storage

After

root@0bba89291a46:/nydus# cargo build --features=fusedev
Updating crates.io index
Compiling time v0.3.14
Compiling nydus-api v0.1.1 (/nydus/api)
Compiling flexi_logger v0.23.3
Compiling nydus-app v0.3.0 (/nydus/app)
Compiling nydus-storage v0.5.0 (/nydus/storage)
^C Building [======================> ] 248/259: nydus-app(build.rs), flexi_logger, nydus-storage, nydus-api

@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22211

@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22212

@anolis-bot
Copy link
Collaborator

@jiangliu , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22213

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Refine the app/build.rs to avoid dependency on the built crate.

The output has changed from
root@liujiang-ecs-dev:~/ws/image-service.git# target-fusedev/release/nydusd -h
Version: 	2.1.0-rc.3.1
Git Commit: 	4f2787d
Build Time: 	Tue, 20 Sep 2022 09:53:16 +0000
Profile: 	release
Rustc: 		rustc 1.61.0 (fe5b13d68 2022-05-18)

Nydus BlobCache/FsCache/Image Service

to

root@0bba89291a46:/nydus# target/debug/nydusd -h
Version: 	2.1.0-rc.3.1
Git Commit: 	e2e6dab0503e72e4bc955464e70ad2ca7c299593
Build Time: 	2022-09-21T09:28:12.131023469Z
Profile: 	debug
Rustc: 		rustc 1.61.0 (fe5b13d68 2022-05-18)

Nydus BlobCache/FsCache/Image Service

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Update flexi-logger to 0.23.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22231

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Avoid dependency of chrono crate

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/22232

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/23788

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@changweige
Copy link
Contributor

/retest

@anolis-bot
Copy link
Collaborator

@changweige , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/23826

@anolis-bot
Copy link
Collaborator

@changweige , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@changweige
Copy link
Contributor

/retest

@anolis-bot
Copy link
Collaborator

@changweige , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/23853

@anolis-bot
Copy link
Collaborator

@changweige , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu requested review from changweige, bergwolf and hsiangkao and removed request for bergwolf and hsiangkao September 23, 2022 05:28
Copy link
Contributor

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 4504e02 into dragonflyoss:master Sep 23, 2022
@jiangliu jiangliu deleted the reduce-dep branch March 28, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants