-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enrich nydus-image print, fix prefetch table layout and other couple of fixes #767
Conversation
@changweige , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/24887 |
@changweige , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/24888 |
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
@@ -219,6 +219,10 @@ impl RafsV6SuperBlock { | |||
self.s_inos = inos.to_le(); | |||
} | |||
|
|||
pub fn inodes_count(&self) -> u64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add doc for this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
src/bin/nydus-image/core/prefetch.rs
Outdated
@@ -168,7 +169,7 @@ impl Prefetch { | |||
if self.policy == PrefetchPolicy::Fs { | |||
let mut prefetch_table = RafsV5PrefetchTable::new(); | |||
for i in self.readahead_patterns.values().filter_map(|v| *v) { | |||
prefetch_table.add_entry(i as u32); | |||
prefetch_table.add_entry(i as u32 + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why plus one here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I made a mistake here. will fix it.
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
5193fdf
to
5084257
Compare
@changweige , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/24891 |
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
rafs v5 han v6 has different root inode numbers. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Because root dir's size is zero before gathering prefetching files. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Rafs v6 can't decide each inode number when walking and building nodes tree. So record those prefetching files' index in nodes array in readahead patterns. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
By default, prefeth_all is true in rafs config. We can't verify prefetch table contents then. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
5084257
to
ab35457
Compare
@changweige , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/24893 |
@changweige , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/24894 |
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
fixes #760