storage: retry timeout chunks for fscache ondemand path #788
Conversation
|
@kevinXYin , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/25903 |
|
@kevinXYin , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
storage/src/cache/cachedfile.rs
Outdated
| @@ -579,7 +579,30 @@ impl FileCacheEntry { | |||
| } | |||
|
|
|||
| if !bitmap.wait_for_range_ready(chunk_index, count)? { | |||
| Err(eio!("failed to read data from storage backend")) | |||
| if !prefetch { | |||
There was a problem hiding this comment.
Minor suggestion:
if prefetch {
return Err(eio!("failed to read data from storage backend"));
}
...
This function is a little over complex, will try to refactor it later
There was a problem hiding this comment.
Thanks , updated.
Yes , this func is too long now , and I remember seems there's still issue for stargz part, may need farther check later.
for fscache ondemand path, if some requested chunks are set to pending by prefetch threads, and wait them timeout, will casue EIO to container side. retry the timeout chunks on ondemand path, minimize EIOs. Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
kevinXYin
force-pushed
the
fscache_fetch_chunks_fix
branch
from
58ab5a3 to
873d696
Compare
|
@kevinXYin , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/25933 |
|
@kevinXYin , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||||||||||||||||||||
|
/retest |
|
@changweige , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26268 |
|
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
I didn't figure out why |
for fscache ondemand path, if some requested chunks are set to pending by prefetch threads, and wait them timeout, will casue EIO to container side.
retry the timeout chunks on ondemand path, minimize EIOs.
Signed-off-by: Xin Yin yinxin.x@bytedance.com