Improve implementation to convert stargz TOC into RAFS fs #792
Conversation
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26647 |
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26651 |
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26654 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
force-pushed
the
stargz-toc
branch
2 times, most recently
from
daa2cec to
cb2c89b
Compare
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26667 |
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26668 |
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26673 |
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26731 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26779 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/26820 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
| } | ||
|
|
||
| match matches.value_of("blob-data-size") { | ||
| None => bail!("no value specified for '--blob-data-size'"), |
There was a problem hiding this comment.
Does it seem must be calculated by blob_size - footer_size in snapshotter?
There was a problem hiding this comment.
It's the toc offset from estargz image. When snapshotter tries to downloaded the TOC, it already gets the blob-data-size by parsing the eStargz footer.
|
LGTM. |
Add more doc for stargz related code. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Do not allocate chunk index for duplicated chunks, so we could get a compact blob compression information array. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
RAFS v6 doesn't support inode digest, so only compute inode digest for v5 when converting stargz. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Set default chunk size to 4M for stargz. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Enforce stricter validation when converting from stargz images. Also generate valid compressed size for chunks reference stargz blob. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Improve implementation to convert stargz TOC into RAFS fs.