Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade clap to 4.0 #822

Merged
merged 1 commit into from
Oct 30, 2022
Merged

upgrade clap to 4.0 #822

merged 1 commit into from
Oct 30, 2022

Conversation

uran0sH
Copy link
Contributor

@uran0sH uran0sH commented Oct 29, 2022

In order to use derive API to refactor, we upgrade clap firstly.

Signed-off-by: Wenyu Huang huangwenyuu@outlook.com

@anolis-bot
Copy link
Collaborator

@uran0sH , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29800

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29801

1 similar comment
@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29801

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29806

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29819

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29879

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

@imeoer
Copy link
Collaborator

imeoer commented Oct 29, 2022

@uran0sH Sorry, please rebase master first.

@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29884

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

src/bin/nydus-image/main.rs Show resolved Hide resolved
src/bin/nydusctl/main.rs Outdated Show resolved Hide resolved
src/bin/nydus-image/main.rs Outdated Show resolved Hide resolved
In order to use derive API to refactor, we upgrade clap firstly.

Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
@anolis-bot
Copy link
Collaborator

@uran0sH , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/29935

@anolis-bot
Copy link
Collaborator

@uran0sH , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

@imeoer imeoer merged commit 9daaff8 into dragonflyoss:master Oct 30, 2022
@uran0sH uran0sH mentioned this pull request Oct 30, 2022
@jiangliu
Copy link
Collaborator

Failed to handle --prefetch-files option:
root@0fba9939116d:/nydus# target/debug/nydusd fuse -M mnt --log-level trace -C nydusd-config1.json -B images/c5016d92995cb3553bd62fc04229f52317d94ac5e76ed65b2a09928ba75fbbf3 --prefetch-files / &
[8] 63069
root@0fba9939116d:/nydus# [2022-10-30 17:06:48.702673 +00:00] INFO [app/src/lib.rs:74] Program Version: v2.1.0-rc.3.1-225-ge799bf75d, Git Commit: "e799bf75d28598291e9f6db4cbcb38be59379cf1", Build Time: "2022-10-30T17:00:17.704862586Z", Profile: "debug", Rustc Version: "rustc 1.61.0 (fe5b13d68 2022-05-18)"
[2022-10-30 17:06:48.702935 +00:00] INFO [src/bin/nydusd/main.rs:516] Set rlimit-nofile to 1000000, maximum 1048576
[2022-10-30 17:06:49.206767 +00:00] ERROR [/root/.cargo/registry/src/github.com-1ecc6299db9ec823/log-panics-2.1.0/src/lib.rs:130] thread 'main' panicked at 'Mismatch between definition and access of prefetch-files. Could not downcast to &str, need to downcast to alloc::string::String
': src/bin/nydusd/main.rs:545
0: <backtrace::capture::Backtrace as core::default::Default>::default
at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.66/src/capture.rs:410:9
1: log_panics::Config::install_panic_hook::{{closure}}
at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/log-panics-2.1.0/src/lib.rs:115:29
2: std::panicking::rust_panic_with_hook
at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/std/src/panicking.rs:702:17
3: std::panicking::begin_panic_handler::{{closure}}
at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/std/src/panicking.rs:588:13
4: std::sys_common::backtrace::__rust_end_short_backtrace
at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/std/src/sys_common/backtrace.rs:138:18
5: rust_begin_unwind
at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/std/src/panicking.rs:584:5
6: core::panicking::panic_fmt
at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/panicking.rs:143:14
7: clap::parser::error::MatchesError::unwrap
at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-4.0.18/src/parser/error.rs:30:9
8: clap::parser::matches::arg_matches::ArgMatches::get_many

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants