2.1 prefetch metrics #892
2.1 prefetch metrics #892
Conversation
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
storage/src/cache/worker.rs
Outdated
| @@ -25,6 +25,8 @@ use crate::cache::{BlobCache, BlobIoRange}; | |||
| use crate::factory::ASYNC_RUNTIME; | |||
| use crate::RAFS_MAX_CHUNK_SIZE; | |||
|
|
|||
| static PREFETCH_BEGIN_TIMING: Once = Once::new(); | |||
There was a problem hiding this comment.
This is a global variable, so it will only be executed once.
How about the case when prefetching multiple images?
There was a problem hiding this comment.
Thanks for your review, it's a good catch. Already fixed it.
In addition, added some comments telling the meaning of the newly added metrics and how to leverage them to estimate prefetch performance.
Record prefech request average latency. Calculate prefetch average bandwidth. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
2.1-prefetch-metrcis
branch
from
4c48504
to
c7b3f89
Compare
anolis-bot
added
anolis_testing
anolis_test_fail
and removed
anolis_test_fail
anolis_testing
labels
|
/retest |
|
@changweige , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/35563 |
|
@changweige , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||
|
/retest |
|
@jiangliu , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/35685 |
|
/retest |
|
@yqleng1987 , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/35726 |
|
@yqleng1987 , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
Please also open a PR for master |
Sure. :-) |
Record prefetch request average latency.
Calculate prefetch average bandwidth.
{ "buffered_backend_size": 0, "data_all_ready": false, "entries_count": 0, "partial_hits": 2657, "prefetch_begin_time_millis": 892, "prefetch_begin_time_secs": 1669262928, "prefetch_cumulative_time_millis": 391525, "prefetch_data_amount": 350224384, "prefetch_end_time_millis": 601, "prefetch_end_time_secs": 1669262933, "prefetch_mr_count": 167, "prefetch_unmerged_chunks": 0, "prefetch_workers": 8, "store_path": "/var/lib/containerd-nydus/cache", "total": 2682, "underlying_files": [ "18798c2c51ee3c0cb84f4e8dbfa3ac5b9116cfac315e3af08405363ea97a2ef7", "d6a08dd25b46d4701c0f3221f20160563fb4b5866b6f4c915a982914adfc00de", "3355a6911228a3502a61b1a53ce9265be17fb07934e6511fbcfdb83438e42de9", "948f80e95f4ab83ae5a202f987fee81f0c860f2e42d82689a758b57887678601", "9957fc0906f7b4b2b1e1fc4a7a6049380bb06d72ac6919e0c06e4134ae70941e", "004656def9b233af509fc65aa91b824071a2ed3c2ee7b1361866b9c06a403949" ], "whole_hits": 0 }