Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

added RankInfo backing field to return RankContainer Ranks or LegacyR… #123

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

ceterisp
Copy link

@ceterisp ceterisp commented Oct 15, 2020

Closes #122 . @aspriddell Thank you for assigning this issue to me. I wasn't sure if this is what you were looking for. I wasn't sure about the JsonProperty data annotation either since I don't know if the json already has a property with rank_info that the program is fetching from. Please let me know and I would be happy to make any changes as quickly as possible.

Thank you for letting me work on this issue!

Copy link
Member

@aspriddell aspriddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also the cast to int that will need addressing, but that's for another PR

DragonFruit.Six.API/Data/SeasonStats.cs Outdated Show resolved Hide resolved
DragonFruit.Six.API/Data/SeasonStats.cs Outdated Show resolved Hide resolved
Copy link
Member

@aspriddell aspriddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aspriddell aspriddell merged commit 6b96efb into dragonfruitnetwork:master Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "shortcut" to the RankContainer from SeasonalStats
2 participants