Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fail to compile on maxOs & windows platform #142

Closed
joeyleeeeeee97 opened this issue Nov 16, 2020 · 4 comments
Closed

[Misc] Fail to compile on maxOs & windows platform #142

joeyleeeeeee97 opened this issue Nov 16, 2020 · 4 comments
Assignees

Comments

@joeyleeeeeee97
Copy link
Contributor

joeyleeeeeee97 commented Nov 16, 2020

Description
Wisp Provides pseudo interfaces for macOS & windows, however in 3d30909918ed0b16925dd025c780ee87f6ef2604 introduced a new function for these two platforms missed.
image

Steps to Reproduce
Steps to reproduce the behavior:
ci.dragonwell-jdk.io/view/build_scripts/job/build-scripts/job

Expected behavior
A clear and concise description of what you expected to happen.

JDK version
8.5.4

Execution environment

  • OS and version: windows & macOs
  • CPU model:
  • Number of CPU cores:
  • Size of physical memory:
  • Inside Linux container?
    • Linux container name (docker, pouch, etc):
    • Linux container version:
@joeyleeeeeee97 joeyleeeeeee97 self-assigned this Nov 16, 2020
joeyleeeeeee97 pushed a commit to joeyleeeeeee97/dragonwell8_jdk that referenced this issue Nov 16, 2020
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows
to fix compile error

Test Plan: windows sanity jtreg test set.

Reviewed-by: zhengxiaolinX, yuleil

Issue: dragonwell-project/dragonwell8#142
joeyleeeeeee97 pushed a commit to joeyleeeeeee97/dragonwell8_jdk that referenced this issue Nov 16, 2020
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows
to fix compile error

Test Plan: windows sanity jtreg test set.

Reviewed-by: zhengxiaolinX, yuleil

Issue: dragonwell-project/dragonwell8#142
@luchsh
Copy link
Contributor

luchsh commented Nov 16, 2020

This is exactly the problem I was worrying about, things may break if you do not keep building them.

@joeyleeeeeee97 but dragonwell version 8.4.5 ??? I do not see such a version from release page of dragonwell, did you mean 8.5.4????

@joeyleeeeeee97
Copy link
Contributor Author

This is exactly the problem I was worrying about, things may break if you do not keep building them.

@joeyleeeeeee97 but dragonwell version 8.4.5 ??? I do not see such a version from release page of dragonwell, did you mean 8.5.4????

Yes. That's a typo.
To avoid this kind of issue in the future I think we need to add nightly or pull-request build for all platforms. And use a single pipeline to trigger them all.

@luchsh
Copy link
Contributor

luchsh commented Nov 16, 2020

This is exactly the problem I was worrying about, things may break if you do not keep building them.
@joeyleeeeeee97 but dragonwell version 8.4.5 ??? I do not see such a version from release page of dragonwell, did you mean 8.5.4????

Yes. That's a typo.
To avoid this kind of issue in the future I think we need to add nightly or pull-request build for all platforms. And use a single pipeline to trigger them all.

There has already been a pull-request build step, maybe you guys can add more platforms to it?

joeyleeeeeee97 pushed a commit to joeyleeeeeee97/dragonwell8_jdk that referenced this issue Nov 17, 2020
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows
to fix compile error

Test Plan: windows sanity jtreg test set.

Reviewed-by: zhengxiaolinX, yuleil

Issue: dragonwell-project/dragonwell8#142
joeyleeeeeee97 pushed a commit to joeyleeeeeee97/dragonwell8_jdk that referenced this issue Nov 17, 2020
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows
to fix compile error

Test Plan: windows sanity jtreg test set.

Reviewed-by: zhengxiaolinX, yuleil

Issue: dragonwell-project/dragonwell8#142
joeyleeeeeee97 pushed a commit to dragonwell-project/dragonwell8_jdk that referenced this issue Nov 17, 2020
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows
to fix compile error

Test Plan: windows sanity jtreg test set.

Reviewed-by: zhengxiaolinX, yuleil

Issue: dragonwell-project/dragonwell8#142
@joeyleeeeeee97
Copy link
Contributor Author

a pull-request build step, maybe you guys can add more platfom

Yes. Great advice. I found 'github action' could do this in a few lines.

joeyleeeeeee97 pushed a commit to dragonwell-project/dragonwell8_jdk that referenced this issue Nov 24, 2020
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows
to fix compile error

Test Plan: windows sanity jtreg test set.

Reviewed-by: zhengxiaolinX, yuleil

Issue: dragonwell-project/dragonwell8#142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants