-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Fail to compile on maxOs & windows platform #142
Comments
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows to fix compile error Test Plan: windows sanity jtreg test set. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#142
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows to fix compile error Test Plan: windows sanity jtreg test set. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#142
This is exactly the problem I was worrying about, things may break if you do not keep building them. @joeyleeeeeee97 but |
Yes. That's a typo. |
There has already been a pull-request build step, maybe you guys can add more platforms to it? |
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows to fix compile error Test Plan: windows sanity jtreg test set. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#142
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows to fix compile error Test Plan: windows sanity jtreg test set. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#142
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows to fix compile error Test Plan: windows sanity jtreg test set. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#142
Yes. Great advice. I found 'github action' could do this in a few lines. |
Summary: Add pseudo getCPUTime in WispEngine on macosx&windows to fix compile error Test Plan: windows sanity jtreg test set. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#142
Description
Wisp Provides pseudo interfaces for macOS & windows, however in 3d30909918ed0b16925dd025c780ee87f6ef2604 introduced a new function for these two platforms missed.
Steps to Reproduce
Steps to reproduce the behavior:
ci.dragonwell-jdk.io/view/build_scripts/job/build-scripts/job
Expected behavior
A clear and concise description of what you expected to happen.
JDK version
8.5.4
Execution environment
The text was updated successfully, but these errors were encountered: