[Misc] Update dragonwell version to 8.3.3 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Update dragonwell version to 8.3.3 and removed DRAGONWELL_JDK_BUILD_NUMBER Test Plan: make.sh saint check Reviewed-by: yuleil, kuaiwei Issue: #92
|
Currently there is a unique 'GA' tag for each update release of OpenJDK, such as 'jdk8u242-ga', so DRAGONWELL_JDK_BUILD_NUMBER is always '-ga' and not needed any more. |
kuaiwei
reviewed
Apr 5, 2020
kuaiwei
reviewed
Apr 5, 2020
| DRAGONWELL_JDK_UPDATE_VERSION=232 | ||
| DRAGONWELL_JDK_BUILD_NUMBER=b09 | ||
| DRAGONWELL_VERSION=8.3.3 | ||
| DRAGONWELL_JDK_UPDATE_VERSION=242 |
There was a problem hiding this comment.
I don't find use of DRAGONWELL_JDK_UPDATE_VERSION in make.sh, do we need this variable?
There was a problem hiding this comment.
It is used by ./common/autoconf/jdk-options.m4, to enable creation of Dragonwell JDK builds from the standard configure && make scripts without involving make.sh.
yuleil
approved these changes
Apr 6, 2020
kuaiwei
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update dragonwell version to 8.3.3 and removed DRAGONWELL_JDK_BUILD_NUMBER
Test Plan:
make.sh saint check
Reviewed-by: yuleil, kuaiwei
Issue: #92