[Wisp] ResourceContainerMXBean #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyleeeeeee97
force-pushed
the
mxb
branch
2 times, most recently
from
8bb529f
to
9e88b66
Compare
joeyleeeeeee97
requested review from
superajun-wsj
and removed request for
zhengxiaolinX
yuleil
reviewed
Feb 9, 2021
| import java.util.stream.StreamSupport; | ||
|
|
||
| public class ResourceContainerMonitor { | ||
| private static Map<Long, ResourceContainer> tenantContainerMap = new HashMap<>(); |
|
|
||
| @Override | ||
| public Long getId() { | ||
| return null; |
There was a problem hiding this comment.
UnsupportedOperationException？
| @@ -85,6 +85,7 @@ private WispControlGroup(int cfsQuotaUs, int cfsPeriodUs) { | |||
| private final AtomicLong currentPeriodStart; | |||
| private final AtomicLong remainQuota; | |||
| volatile Boolean destroyed = false; | |||
| private long totalConsume = 0; | |||
There was a problem hiding this comment.
Inaccurate
add a comment to describe
| import java.lang.management.PlatformManagedObject; | ||
| import java.util.List; | ||
|
|
||
| public interface ResourceContainerMXBean extends PlatformManagedObject { |
There was a problem hiding this comment.
add java doc for public interface
Summary: Add ResourceContainerMXBean, currently only support CPU resource amount. Test Plan: jtreg test/com/alibaba/ Reviewed-by: yuleil, zhengxiaolinX Issue: dragonwell-project/dragonwell8#206
superajun-wsj
approved these changes
Mar 9, 2021
yuleil
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add ResourceContainerMXBean, currently only
support CPU resource amount.
Test Plan: jtreg test/com/alibaba/
Reviewed-by: yuleil, superajun-wsj
Issue: dragonwell-project/dragonwell8#206