[Wisp] Fix WispEventPump epollWait IllegalArgumentException #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In wisp Monolithic Epoll, we clear Epoll fd after the park. But at shutdown, an interruption may break this and leave an uncleared epoll array on wise task, IllegalArgumentException may happen when reuse this wispTask. Test Plan: jtreg test/wisp2 Reviewed-by: yuleil, zhengxiaolinX Issue: dragonwell-project/dragonwell8#208
joeyleeeeeee97
force-pushed
the
fix_epfd
branch
from
dd4479a
to
86bc194
Compare
zhengxiaolinX
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In wisp Monolithic Epoll, we clear Epoll fd after the park.
But at shutdown, an interruption may break this and leave an uncleared
epoll array on wise task, IllegalArgumentException may happen when reuse
this wispTask.
Test Plan: jtreg test/wisp2
Reviewed-by: yuleil, zhengxiaolinX
Issue: dragonwell-project/dragonwell8#208