Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/hunspell: check content origins in parallel #123

Merged
merged 2 commits into from
Oct 28, 2020
Merged

feat/hunspell: check content origins in parallel #123

merged 2 commits into from
Oct 28, 2020

Conversation

drahnr
Copy link
Owner

@drahnr drahnr commented Oct 27, 2020

What does this PR accomplish?

Makes hunspell iterate over content origins in parallel, which yields a huge speedup on machines with more than 2 cores.

  • 🦚 Feature

Ref #104 .

Changes proposed by this PR:

Introduce rayon to parallelize iteration execution.

Notes to reviewer:

This does not yet use a mpsc to prepare individual suggestion sets per origin, but merges them into one still. So for large projects there is still a inactivity time noticable. This will be addressed in futures commits.

📜 Checklist

  • Works on the ./demo sub directory
  • Test coverage is excellent and passes
  • Documentation is thorough

@drahnr
feat/hunspell: check content origins in parallel
9c7440b 
On multicore machines the speedup is significant.
@drahnr drahnr requested a review from KuabeM October 27, 2020 09:05
@drahnr drahnr self-assigned this Oct 27, 2020
@drahnr drahnr added checker / hunspell hunspell checker related topics enhancement 🦚 New feature or request labels Oct 27, 2020
@drahnr drahnr requested a review from laysauchoa October 27, 2020 14:59
KuabeM
KuabeM approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@KuabeM KuabeM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small step for API but a (first) big step for performance?

@drahnr drahnr merged commit ba6337c into master Oct 28, 2020
@drahnr drahnr deleted the bernhard-speedy branch October 28, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuabeM KuabeM KuabeM approved these changes

@laysauchoa laysauchoa Awaiting requested review from laysauchoa

Assignees

@drahnr drahnr

Labels
checker / hunspell hunspell checker related topics enhancement 🦚 New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drahnr @KuabeM