refactor: allow async for latency sensitive commands #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
changed the title
It turns out, that while maintaining max throughput, latency is far from perfect. Moving from a max throughput to a min latency model the user is prompted much much faster with the first output. For CI where stdout / stderr are pumped to file, this also allows for an improved resource pattern.
The new approach demands that the checkers can hold state to avoid repeated initialization work. Prior, this wasn't necessary since the checkers operasted on one giant document containing all files to check.
drahnr
force-pushed
the
bernhard-async
branch
from
efded98 to
9200145
Compare
drahnr
added
checker
KuabeM
reviewed
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out, that while maintaining max throughput, latency is far
from perfect. Moving from a max throughput to a min latency model
the user is prompted much much faster with the first output. This is especially important for large~ish codebases and a full run.
For CI where stdout / stderr are piped to files, this also
allows for an improved resource usage pattern.
What does this PR accomplish?
Ref #104
Changes proposed by this PR:
Make a few commands focus on latency rather than pure compute time needed.
Notes to reviewer:
📜 Checklist
./demosub directory