Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deps #284

Merged
merged 8 commits into from
Nov 23, 2022
Merged

bump deps #284

merged 8 commits into from
Nov 23, 2022

Conversation

drahnr
Copy link
Owner

@drahnr drahnr commented Oct 20, 2022

What does this PR accomplish?

Bumps dependencies

  • 🪣 Misc

📜 Checklist

  • Works on the ./demo sub directory
  • Test coverage is excellent and passes
  • Documentation is thorough

@drahnr drahnr force-pushed the bernhard-bump-deps branch from e53bade to f68ad7e Compare October 20, 2022 08:17
@drahnr drahnr force-pushed the bernhard-bump-deps branch from f68ad7e to cf2b6f6 Compare November 8, 2022 12:58
@gilescope
Copy link

We really will need the toml edit crate bumped as if you try and run the tool when the new Cargo.toml workspace properties are used then it blows up. (E.g. version.workspace = true in some of the crates in the workspace rather than specifying the version in multiple locations.)

@drahnr
Copy link
Owner Author

drahnr commented Nov 22, 2022

I'll take a look tomorrow~ish

If you have a regression test handy, that'd be much appreciated. The comment is not quite enough. Why would it blow up? Because if how it's used here or in the lib itself?

@gilescope
Copy link

It's something to do with '.' properties and how that's interpreted. I have been upgrading every tool I come across to latest toml edit which does understand the latest format. It's not just you - I think we are the first to use this stuff.

@gilescope
Copy link

Here's an example PR of what we're trying to do: paritytech/polkadot#6095

@drahnr drahnr force-pushed the bernhard-bump-deps branch from cf2b6f6 to 8de6afc Compare November 23, 2022 09:32
@drahnr
Copy link
Owner Author

drahnr commented Nov 23, 2022

that PR fails since the bash eval already fails, it doesn't even get to the point cargo spellcheck tries to eval

cargo spellcheck list-files -vvv $(git diff --diff-filter=AM --name-only $(git merge-base ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH} -- :^bridges))

@gilescope
Copy link

This is the error I get if we ignore bash:

[2022-11-23T09:44:24Z DEBUG cargo_spellcheck::config::args] Using /home/gilescope/git/polkadot1/Cargo.toml manifest as anchor file
Error: 
   0: Failed to parse cargo manifest: /home/gilescope/git/polkadot1/Cargo.toml
   1: invalid type: map, expected a sequence for key `package.authors` at line 11 column 21

@drahnr drahnr merged commit fb43c14 into master Nov 23, 2022
@drahnr drahnr deleted the bernhard-bump-deps branch November 23, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants