-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump deps #284
bump deps #284
Conversation
e53bade
to
f68ad7e
Compare
f68ad7e
to
cf2b6f6
Compare
We really will need the toml edit crate bumped as if you try and run the tool when the new Cargo.toml workspace properties are used then it blows up. (E.g. |
I'll take a look tomorrow~ish If you have a regression test handy, that'd be much appreciated. The comment is not quite enough. Why would it blow up? Because if how it's used here or in the lib itself? |
It's something to do with '.' properties and how that's interpreted. I have been upgrading every tool I come across to latest toml edit which does understand the latest format. It's not just you - I think we are the first to use this stuff. |
Here's an example PR of what we're trying to do: paritytech/polkadot#6095 |
cf2b6f6
to
8de6afc
Compare
that PR fails since the bash eval already fails, it doesn't even get to the point cargo spellcheck tries to eval cargo spellcheck list-files -vvv $(git diff --diff-filter=AM --name-only $(git merge-base ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH} -- :^bridges)) |
This is the error I get if we ignore bash:
|
What does this PR accomplish?
Bumps dependencies
📜 Checklist
./demo
sub directory