use https://kubernetes.default instead of just https://kubernetes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
commented
Nov 3, 2017
agilgur5
commented
- otherwise it doesn't work if it's in a different namespace
agilgur5
force-pushed
the
kubernetes-default
branch
from
94bf7d2 to
cf8e845
Compare
- otherwise it doesn't work if it's in a different namespace
mstemm
added a commit
that referenced
this pull request
Feb 20, 2018
Originally raised in #296, but since then we documented rbac and without-rbac methods, so mirroring the change here.
|
Since this PR was proposed, we made some other changes to document rbac and non-rbac methods for deploying falco, so this PR has conflicts. I carried the change over in a new PR #325, so I'll close this one. |
mstemm
added a commit
that referenced
this pull request
Feb 20, 2018
* Use kubernetes.default to reach k8s api server Originally raised in #296, but since then we documented rbac and without-rbac methods, so mirroring the change here. * Mount docker socket/dev read-write This matches the direct docker run commands, which also mount those resources read-write.
|
Same note as #295 (comment):
|
|
Indeed, I'll make sure I stay with the original PRs in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.