docker socket and /dev should not be read-only in daemonset #295
Conversation
agilgur5
commented
Nov 3, 2017
agilgur5
commented
- these aren't read-only in any other examples
agilgur5
force-pushed
the
read-only-daemonset
branch
from
964e9b2 to
e5ab1dc
Compare
- these aren't read-only in any other examples
|
Good point! We made some changes since this PR was proposed to split the falco daemonset into rbac and non-rbac methods, so I'll make the change in a separate PR #325. |
|
@mstemm it is courtesy to ensure contributors are credited with their changes. I'm personally quite copious in projects I maintain to ensure contributors receive their due credit, even if I have made changes to their changes (I would be committer and they author), and particularly so when there are conflicts that occurred months after their PR. Just my 2 cents... |
|
Sorry, you're right--I should have waited for an updated PR that had the same changes applied to the updated files, which got moved to new subdirectories. I only went ahead with making the same changes on the updated files myself, as it was a fairly small change. I'll make sure I stay with the original PRs in the future. |
|
Ok, thanks for the note! In the past, I've also just taken commits and amended or rebased them myself, so closing the PR, but leaving the contributor as the author of the commit that gets put into master (examples are probably better than words: agilgur5/react-signature-canvas#14 (comment)). It's something I've seen often in projects that follow a rebase style (e.g. Django) |
