Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple instances on Mac #19

Merged
merged 4 commits into from
Oct 5, 2017
Merged

Allow multiple instances on Mac #19

merged 4 commits into from
Oct 5, 2017

Conversation

davideschiera
Copy link
Contributor

A couple of improvements on Mac OS:

  • Allow running multiple instances
  • Ensure the app terminates the API server when you close it via X button (or CMD+W) and starts again when you open it from Dock

@davideschiera davideschiera self-assigned this Oct 4, 2017
@davideschiera davideschiera merged commit 71a6553 into dev Oct 5, 2017
@davideschiera davideschiera deleted the multiple-instances branch October 5, 2017 05:49
ApsOps pushed a commit to ApsOps/sysdig-inspect that referenced this pull request Oct 10, 2017
@davideschiera @ApsOps
Allow multiple instances on Mac (draios#19)
6aa8e3b 
* Make sure to setup listeners every time you create the window

* Close server when all windows are closed

* Unused parameter

* Remove unnecessary window close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davideschiera davideschiera

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davideschiera