Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket/bind handling #1071

Merged
merged 2 commits into from
Mar 9, 2018
Merged

socket/bind handling #1071

merged 2 commits into from
Mar 9, 2018

Conversation

mattpag
Copy link
Contributor

@mattpag mattpag commented Mar 8, 2018

Minor modifications/fixes to the socket,bind parsers:

  • Use the correct sockinfo when setting the fd l4 protocol
  • Extract the ip address and set the role during bind

mattpag added 2 commits March 8, 2018 14:58
@mattpag
Use the right sockinfo in sinsp_parser::add_socket()
f5ec92c 
While adding a new ipv6 socket, the m_type is correctly set
to SCAP_FD_IPV6_SOCK but m_ipv4info was used to set the l4proto.
@mattpag
Extract ip address in sinsp_parser::parse_bind_exit()
ca06262 
For ipv4 and ipv4-mapped ipv6, extract the ip address passed to bind.
Also, set the role to server since they are servsock.
@mattpag mattpag requested review from luca3m and mstemm March 8, 2018 14:24
@mattpag mattpag merged commit 0b9e003 into dev Mar 9, 2018
@mattpag mattpag deleted the early-network-setting branch March 9, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstemm mstemm mstemm approved these changes

@luca3m luca3m Awaiting requested review from luca3m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattpag @mstemm