Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_code type should be long not int [SMAGENT-951] #1159

Merged
merged 1 commit into from
Jun 26, 2018
Merged

http_code type should be long not int [SMAGENT-951] #1159

merged 1 commit into from
Jun 26, 2018

Conversation

h-w-chen
Copy link
Contributor

based on curl_easy_getinfo doc, the type for code query it is expecting is long*, not int*.

changed it to long, confirmed it work fine.

@h-w-chen h-w-chen requested a review from anoop-sysd June 25, 2018 21:24
@anoop-sysd
Copy link
Contributor

Verified the fix.

As pointed out by @h-w-chen , this issue is caused by #1127.

@anoop-sysd anoop-sysd changed the title http_code type should be long not int http_code type should be long not int [SMAGENT-951] Jun 26, 2018
@anoop-sysd anoop-sysd merged commit aa60302 into dev Jun 26, 2018
@anoop-sysd anoop-sysd deleted the curl_easy_getinfo-param-type-changed branch June 26, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoop-sysd anoop-sysd anoop-sysd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-w-chen @anoop-sysd