Update probe module for kernel 4.11 #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While nsec_to_clock_t is declared in an available header file, we need to define it because the kernel doesn't export the symbol.
ret2libc
reviewed
May 4, 2017
driver/ppm_cputime.c
Outdated
| #else | ||
| /* | ||
| * max relative error 5.7e-8 (1.8s per year) for USER_HZ <= 1024, |
There was a problem hiding this comment.
spaces/tabs (it looks like they were wrong even in the kernel file)
driver/ppm_cputime.c
Outdated
| #if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)) | ||
| #include <linux/time.h> | ||
| #include <asm-generic/param.h> |
There was a problem hiding this comment.
Probably better to use linux/param.h
luca3m
approved these changes
May 5, 2017
bertocci
pushed a commit
that referenced
this pull request
May 5, 2017
* 4.11 kernel changes: remove cputime_t and helpers * Use nsec_to_clock_t() where needed While nsec_to_clock_t is declared in an available header file, we need to define it because the kernel doesn't export the symbol. * Review fixes - better param.h include and indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #824
I tested using
sysdig -c topprocs_cpuandcsysdig