Ensure all extracted filtercheck vals have lengths #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a prior PR (#624) I did a pass ensuring that the length is properly set for string-based extractions. I want to complete this work by ensuring it works for all fields extracted by a filtercheck. This way you can use the hashing/equality operators in filter_value.h to group collections by filtercheck value.
mattpag
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a prior PR (#624) I did a pass
ensuring that the length is properly set for string-based extractions. I
want to complete this work by ensuring it works for all fields extracted
by a filtercheck. This way you can use the hashing/equality operators in
filter_value.h to group collections by filtercheck value.
This fixes https://sysdig.atlassian.net/browse/SSPROD-317.