check for multiple inverse matches

[mistadave]

Current behaviour

The check checkEventConditionPatterns returns after first match is true, which doesn't allow to check multiple wildcards inverse.

New behaviour

This change allows in the event rules to set multiple path filters with inverse matches.
Which allows for matching to any kind of file except for those inverse matches (acts as an exclusions list).

All tests on the eventmanager_test.go passed.

Known limitations

Probably doesn't work with mixed path filters. Which I think does not make sense anyway, because a matching pattern always exclude any other inverse matches.

Changes

• update function checkEventConditionPatterns for multiple inverse patterns
  • Use the matches variable to keep track of the state if condition matches pattern.
• extend TestDoubleStarMatching with inverse flag
• write test for multiple douple start matches, also for inverse matches

[drakkan]

Hello, thank you for your contribution. I'll give a look the next weekend. Can you please fix the DCO check in the meantime?

[drakkan]

Can we just return true here?

[mistadave]

yes that possible, will update that

[drakkan]

This patch can be merged but please apply the same logic also in checkEventGroupConditionPatters

sftpgo/internal/common/eventmanager.go

Line 1161 in 76964a6

func checkEventGroupConditionPatters(groups []sdk.GroupMapping, patterns []dataprovider.ConditionPattern) bool {

to have uniform behavior. Thank you!

[mistadave]

Hello drakkan,
I've added direct return and added same behaviour to checkEventGroupConditionPatterns(). Did also find a spellmistake.

[drakkan]

Hello drakkan, I've added direct return and added same behaviour to checkEventGroupConditionPatterns(). Did also find a spellmistake.

Thank you, but please fix the DCO check. I'll do some tests with groups this weekend to make sure the behavior is uniform.

[mistadave]

Yes, just saw it. Will fix them.

[drakkan]

checkEventGroupConditionPatterns seems not consistent, for example if you have something like this

Patterns := []dataprovider.ConditionPattern{
		{
			Pattern:      "group1",
			InverseMatch: true,
		},
		{
			Pattern:      "group2",
			InverseMatch: true,
		},
	}

groups = []sdk.GroupMapping{
		{
			Name: "group1",
			Type: sdk.GroupTypePrimary,
		},
		{
			Name: "group4",
			Type: sdk.GroupTypePrimary,
		},
	}

I think the check should return false because groups must not contains group1 and group4, with your changes it returns true. I'll try to fix myself

[drakkan]

Hello @mistadave

thank you again for this contribution. We have recently updated our contribution policy and we now require signing a CLA. Agreeing to the CLA clarifies your rights as a contributor and at the same time protects SFTPGo and its users.

More details here

You can use the following URL to sign the CLA

https://cla-assistant.io/drakkan/sftpgo?pullRequest=1332

Thank you!