feat: 🎸 missing comment rule #16
Conversation
identify localized strings which do not have a comment in the `.strings` file ✅ Closes: dral3x#15
There was a problem hiding this comment.
Thanks for working on this! I really appreciate it!
I see no change to the .xcodeproj file, and when I run the tool via Xcode, the compiler fails. Can you please fix that?
I've also found some possible cleanup to be addressed (see comments below). Nothing major of course, but it's always better not having dead code around.
Thanks!
Sources/StringsLintFramework/Rules/Lint/MissingCommentRule.swift
Outdated
Show resolved
Hide resolved
Sources/StringsLintFramework/Rules/Lint/MissingCommentRule.swift
Outdated
Show resolved
Hide resolved
building StringsLint in Xcode when opening package by double-clicking on Package.swift worked fine before. Also building via make install worked before.
|
I deleted the unused code. I added the new files but I could not verify your workflow. I was not able to build with .xcodeproj / workspace even before my changes. Hope by adding the new files it works for you now. If not then I would need your help to understand and run your workflow. I don't know if you expected me to run |
There was a problem hiding this comment.
I didn't know the .xcodeproj was not working for you, sorry about that.
I was not expecting the usage of generate-xcodeproj command, but thanks for letting me know about its deprecation!
Anyway, thanks for integrating my requests. Now everything looks awesome! 👏
I'll merge this PR and release a new version asap.
identify localized strings which do not have a comment in the
.stringsfile
✅ Closes: #15