Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not regenerate env/dev/ files on re-natal use-figwheel #13

Closed
drapanjanas opened this issue Jan 24, 2016 · 0 comments
Closed

Do not regenerate env/dev/ files on re-natal use-figwheel #13

drapanjanas opened this issue Jan 24, 2016 · 0 comments

Comments

@drapanjanas
Copy link
Owner

Currently there is Reagent specific code in env/dev/*/main.cljs. Regenerating these files makes it impossible to use om-next.
To support Android simulators, re-natal might just update fighweel url to set simulator specific IP address instead of regenerating whole file.
Actually, there is no need to change host for iOS at all. Only for android host might be localhost, 10.0.2.2 or 10.0.3.2.
Probably need to create dedicated command for changing host only for android and remove this concern from use-figwheel.
drapanjanas added a commit that referenced this issue Jan 24, 2016
@drapanjanas
do not regenerate env/dev* files in use-figwheel command #13
b601f62 
- No need to change host for iOS it is always localhost
- For android simulators, update only the host in figwheel URL instead of overwriting whole file
- env/dev can be removed from .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drapanjanas