Use figwheel 0.5.18 #217
Merged
Use figwheel 0.5.18 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update piggieback dependency from cemerick/piggieback to cider piggie…
|
it really helps. Thank you. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I upgraded to figwheel 0.5.18 to solve an issue with the clojurescript repl in cider 0.21:
clojure-emacs/cider#2571
Upon doing so, hot reloading broke, but oddly still worked when using an older version of figwheel-bridge.js prior to the changes in #185. I narrowed down the fix to what you see here in this PR, but I'd like to better understand what the underlying issue is, and perhaps there's a better fix that allows us to continue using
importIndexJs?This PR also includes the changes in #213.