Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fake/mock): allow pre-programming methods with callbacks #172

Merged
merged 22 commits into from
Jan 30, 2023
Merged

feat(fake/mock): allow pre-programming methods with callbacks #172

merged 22 commits into from
Jan 30, 2023

Conversation

crookse
Copy link
Member

@crookse crookse commented Oct 21, 2022 •
edited
Loading

@crookse crookse changed the title feat(fake/mock): allow pre-programming methods with specific set of args feat(fake/mock): allow pre-programming methods with callbacks Dec 11, 2022
@crookse crookse force-pushed the feat/arg-expectations branch 2 times, most recently from 95ae531 to 3e96232 Compare December 11, 2022 06:20
@crookse crookse added the Type: Minor Merging this pull request results in a minor version increment label Dec 11, 2022
ebebbington
ebebbington requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@ebebbington ebebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple minor nitpicky things

console/build_esm_lib.ts Outdated Show resolved Hide resolved
console/build_esm_lib.ts Outdated Show resolved Hide resolved
@Guergeiro @ebebbington
Apply suggestions from code review
b2da8c3 
Co-authored-by: Edward Bebbington <47337480+ebebbington@users.noreply.github.com>
@crookse
Copy link
Member Author

crookse commented Dec 19, 2022

❤️ @Guergeiro @ebebbington

I'm writing the docs now

This was referenced Dec 23, 2022
Merged
Merged
@crookse crookse mentioned this pull request Dec 23, 2022
Merged
@crookse
Copy link
Member Author

crookse commented Dec 23, 2022

@Guergeiro @ebebbington , docs are up: drashland/website-v2#193

@crookse crookse merged commit 73ec134 into main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guergeiro Guergeiro Guergeiro approved these changes

@ebebbington ebebbington Awaiting requested review from ebebbington

Assignees
No one assigned
Labels
Type: Minor Merging this pull request results in a minor version increment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(fake/mock): allow pre-programming methods with callbacks
3 participants
@crookse @Guergeiro @ebebbington