-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
61 add support for custom browser path #62
61 add support for custom browser path #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things:
- Have you tested this with your Brave browser? I'm not confident we should say we support other chromium based browsers because we don't actually test them (yet), so it's unsure if they will actually work - though I might do this in a separate PR to avoid the headache for you (unless you want to), i think it's just a matter of installing brave on the CI workflow and in the dockerfile, then an extra integration test that checks it works when passing in the path to brave
Though, saying that, maybe it isn't needed, maybe the fact we offer the option to use a different path is enough?
- Ill need to write the docs for this before we can release this feature, or you can as well if you feel like it and are familiar with the frontend/vue :)
|
That is perfect :D That is really great news that it just works, i know you mentioned it should just work anyway, but it's nice to see it has done :) I do see your your point bout point 1 though, I think us saying "We also support other browsers like Brave, you can set the path to do this" is enough
Feel free :) It's not a problem if not, we can discuss it on the discord |
Fixes #61
Summary
Other Notes
This pull request addresses the feature of using a chromium/gecko engine based browser, alternative to the currently prevalent Chrome/Firefox. The feature works as long as the browser engines are the same as the Original (Chrome/Firefox) browsers.