Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove default url when creating a headless client #82

Merged
merged 7 commits into from
Nov 27, 2021

Conversation

ebebbington
Copy link
Member

It's useless, it offers nothing. If anything, it's detrimental, because it means that every test needs to wait for the default page to load

@ebebbington ebebbington added the Type: Chore Merging this pull request results in a patch version increment label Aug 11, 2021
@ebebbington ebebbington marked this pull request as draft August 12, 2021 18:05
@ebebbington ebebbington linked an issue Aug 12, 2021 that may be closed by this pull request
@ebebbington ebebbington marked this pull request as ready for review August 12, 2021 18:49
Copy link
Member

@crookse crookse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@crookse crookse merged commit 2480033 into main Nov 27, 2021
@crookse crookse deleted the remove-default-url branch November 27, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Merging this pull request results in a patch version increment
Development

Successfully merging this pull request may close these issues.

Remove default url as a config option
2 participants