Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add assertNoConsoleErrors() #98

Merged
merged 7 commits into from
Dec 18, 2021
Merged

feat: Add assertNoConsoleErrors() #98

merged 7 commits into from
Dec 18, 2021

Conversation

ebebbington
Copy link
Member

No description provided.

@ebebbington ebebbington added the Type: Minor Merging this pull request results in a minor version increment label Dec 16, 2021
@ebebbington ebebbington linked an issue Dec 16, 2021 that may be closed by this pull request
Add assert NoConsoleErrors method? #94
Closed
ebebbington
ebebbington commented Dec 16, 2021
View reviewed changes
src/page.ts
for (const i in errorLogs) {
errorStr += `${i + 1}: ${errorLogs[i]}\n`;
}
throw new AssertionError(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dingus, this will always throw

@ebebbington ebebbington merged commit 12d4c83 into main Dec 18, 2021
@ebebbington ebebbington deleted the assert-no-console-errors branch December 18, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crookse crookse Awaiting requested review from crookse

@Guergeiro Guergeiro Awaiting requested review from Guergeiro

Assignees
No one assigned
Labels
Type: Minor Merging this pull request results in a minor version increment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add assert NoConsoleErrors method?
1 participant
@ebebbington