-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Using normalized package architecture #21
Merged
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5854812
:truck: Renamed app folder to drawbot
Sigmanificient 77460af
:see_no_evil: Updated gitignores
Sigmanificient 58e64db
:package: Converting bot to a simple package
Sigmanificient b88ef7d
:truck: Added package entry point
Sigmanificient 6779b94
:adhesive_bandage: Sorted types & imports
Sigmanificient a0b389b
:memo: Updated documentation
Sigmanificient c2e6689
:package: Further improvements for package installation
Sigmanificient a085d75
:wrench: Added a simple Makefile
Sigmanificient c7b1124
:bug: Renamed types => json_types for circular import fix
Sigmanificient 19a8965
:sparkles: Added user-friendly print on Login Failure
Sigmanificient 30d45aa
:art: Removed useless typing
Sigmanificient 88c16dc
:recycle: Factorized fetch json
Sigmanificient 155e429
:art: Quick reformat
Sigmanificient bf55b47
:truck: Moved readme to docs
Sigmanificient 848d1c1
:wrench: Improving setup.cfg & added pyproject.toml
Sigmanificient 22ebebb
:adhesive_bandage: Fixed stupid codacy warning
Sigmanificient 5283073
:truck: Moved json types to json utils
Sigmanificient a796825
:rewind: Re-added config.json example in readme
Sigmanificient 7decaea
:adhesive_bandage: Fixed stupid codacy warning ~2
Sigmanificient File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
venv | ||
.idea | ||
app/pronote.json | ||
app/config.json | ||
app/devoirs.json | ||
app/grades.json | ||
drawbot/pronote.json | ||
|
||
__pycache__ | ||
/desktop.ini | ||
|
||
*.egg-info |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
VENV = venv | ||
VBIN = $(VENV)/bin | ||
|
||
all: start | ||
|
||
clean: | ||
rm -rf venv | ||
rm -rf *.egg-info | ||
rm -rf __pycache__ | ||
rm vars/*.json | ||
|
||
$(VBIN)/python: | ||
python -m venv venv | ||
chmod +x venv/bin/activate | ||
./venv/bin/activate | ||
pip install -e . | ||
|
||
vars/config.json: | ||
cp vars/config.json.example vars/config.json | ||
|
||
start: $(VBIN)/python vars/config.json | ||
python drawbot | ||
|
||
.PHONY: all clean start |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
"""A Pronote notifier discord bot.""" | ||
from .bot import Bot | ||
|
||
__version__: str = "2.0.0" | ||
__author__: str = "Drawbu" | ||
__maintainer__: str = "Sigmanificient" | ||
|
||
__all__ = ("Bot",) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
from app.bot import Bot | ||
from drawbot import Bot | ||
|
||
|
||
def main() -> None: | ||
def main(): | ||
"""Entry point to run the bot client.""" | ||
bot = Bot() | ||
bot.run() | ||
|
||
|
||
if __name__ == '__main__': | ||
if __name__ == "__main__": | ||
main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
dev.py |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why deleting this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a
config.json.example
file people can directly copy and rename. Since the content is within the example file, it isn't much useful in the readme, i believePlus having a example file within the vars folder should avoid people to try creating a config.json at another locater, i hope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it will be easier for some, but harder for a majority. People using this bot are in majority beginners, so we need to make this accessible. I'm just gonna adding it back, and we'll have both available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure