Fix: Persist settings on load and improve utils robustness #753
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes drawdb-io#752 - Initialize SettingsContext state lazily from localStorage to ensure settings are loaded before first render, preventing reset to defaults - Add error handling to dataURItoBlob to handle invalid inputs gracefully
|
@shalini-saloni is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #752
This PR addresses two bugs:
SettingsContextwas initializing state with defaults and only reading fromlocalStoragein auseEffect, causing settings to be overwritten on every page load.dataURItoBloblacked error handling for malformed data URIs.Changes
SettingsContextstate lazily fromlocalStorageto ensure settings are loaded before first renderdataURItoBlobinutils.jsto handle invalid inputs gracefullyTesting
dataURItoBlobwith valid and invalid inputs