fix(ui): cleanup DOMs when dispose (#1663)

* fix: cleanup DOMs on dispose * refactor(sheet-ui): simplified dispose Co-authored-by: Wenzhao Hu <wzhudev@gmail.com> --------- Co-authored-by: Wenzhao Hu <wzhudev@gmail.com>
dream-num · Mar 23, 2024 · adff6fb · adff6fb
1 parent b695b2e
commit adff6fb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/packages/sheets-ui/src/services/clipboard/clipboard.service.ts b/packages/sheets-ui/src/services/clipboard/clipboard.service.ts
@@ -116,6 +116,8 @@ export class SheetClipboardService extends Disposable implements ISheetClipboard
         });
         this._usmToHtml = new USMToHtmlService();
         this._copyContentCache = new CopyContentCache();
+
+        this.disposeWithMe(this._htmlToUSM);
     }
 
     copyContentCache(): CopyContentCache {

diff --git a/packages/sheets-ui/src/services/clipboard/html-to-usm/converter.ts b/packages/sheets-ui/src/services/clipboard/html-to-usm/converter.ts
@@ -383,6 +383,10 @@ export class HtmlToUSMService {
             }
         }
     }
+
+    dispose() {
+        document.body.removeChild(this.htmlElement);
+    }
 }
 
 /**

diff --git a/packages/ui/src/views/App.tsx b/packages/ui/src/views/App.tsx
@@ -83,6 +83,9 @@ export function App(props: IUniverAppProps) {
         return () => {
             // batch unsubscribe
             subscriptions.forEach((subscription) => subscription.unsubscribe());
+
+            // cleanup
+            document.body.removeChild(portalContainer);
         };
     }, [localeService, messageService, mountContainer, portalContainer, themeService.currentTheme$]);