fix(formula): fix decimal bug

dream-num · Jul 19, 2024 · d78d2bc · d78d2bc
1 parent fcc7e6b
commit d78d2bc
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/packages/engine-formula/src/functions/math/decimal/index.ts b/packages/engine-formula/src/functions/math/decimal/index.ts
@@ -92,6 +92,10 @@ export class Decimal extends BaseFunction {
                 return NumberValueObject.create(0);
             }
 
+            if (!this.isValidCharForRadix(textValue, radixValue)) {
+                return ErrorValueObject.create(ErrorType.NUM);
+            }
+
             const result = Number.parseInt(textValue, radixValue);
 
             if (Number.isNaN(result)) {
@@ -107,4 +111,20 @@ export class Decimal extends BaseFunction {
 
         return resultArray;
     }
+
+    private isValidCharForRadix(text: string, radix: number): boolean {
+        for (const char of text) {
+            const charCode = char.toUpperCase().charCodeAt(0);
+
+            if (radix <= 10 && !(charCode >= 48 && charCode < 48 + radix)) { // '0' to 'radix-1'
+                return false;
+            }
+
+            if (radix > 10 && !((charCode >= 48 && charCode < 58) || (charCode >= 65 && charCode < 65 + radix - 10))) { // '0' to '9'  'A' to 'A+radix-10'
+                return false;
+            }
+        }
+
+        return true;
+    }
 }