fix: fix invalid color str in paste #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2783 +/- ##
==========================================
- Coverage 26.31% 26.20% -0.11%
==========================================
Files 1706 1729 +23
Lines 91390 91897 +507
Branches 19345 19433 +88
==========================================
+ Hits 24045 24080 +35
- Misses 67345 67817 +472 ☔ View full report in Codecov by Sentry. |
View Deployment
|
jikkai
reviewed
Jul 16, 2024
packages/ui/src/utils/cell.ts
Outdated
Comment on lines
208
to
218
| const colorKit = new ColorKit(value); | ||
| if (colorKit.isValid) { | ||
| const rgbStr = colorKit.toRgbString(); | ||
| styleList.cl = { | ||
| rgb: rgbStr, | ||
| }; | ||
| } else { | ||
| styleList.cl = { | ||
| rgb: 'rgb(0,0,0)', | ||
| }; | ||
| } |
There was a problem hiding this comment.
styleList.cl = {
rgb: colorKit.isValid ? colorKit.toRgbString() : 'rgb(0,0,0)',
};
jikkai
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
Pull Request Checklist