Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix invalid color str in paste #2783

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: fix invalid color str in paste #2783

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932b095
fix: fix invalid color str in paste
ybzky Jul 16, 2024
9fc3af2
chore: optimize writing
ybzky Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/ui/src/utils/cell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,17 @@ export function handleStringToStyle($dom?: HTMLElement, cssStyle: string = '') {
}
// font color
else if (key === 'color') {
const rgbStr = new ColorKit(value).toRgbString();
styleList.cl = {
rgb: rgbStr,
};
const colorKit = new ColorKit(value);
if (colorKit.isValid) {
const rgbStr = colorKit.toRgbString();
styleList.cl = {
rgb: rgbStr,
};
} else {
styleList.cl = {
rgb: 'rgb(0,0,0)',
};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

styleList.cl = {
  rgb: colorKit.isValid ? colorKit.toRgbString() : 'rgb(0,0,0)',
};

}
// fill color / background
else if (key === 'background' || key === 'background-color') {
Expand Down
Loading