Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): doc support table #2814

Merged
merged 88 commits into from
Aug 6, 2024
Merged

feat(docs): doc support table #2814

merged 88 commits into from
Aug 6, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jul 18, 2024

close #2809

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 12.36264% with 2552 lines in your changes missing coverage. Please review.

Project coverage is 26.40%. Comparing base (4cda2fb) to head (e57c47f).
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/docs/src/commands/commands/table/table.ts 2.06% 285 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 192 Missing ⚠️
...mponents/docs/text-selection/convert-rect-range.ts 0.00% 161 Missing ⚠️
...cs/text-selection/text-selection-render-manager.ts 0.00% 138 Missing ⚠️
...ommands/commands/table/doc-table-delete.command.ts 0.00% 133 Missing ⚠️
...ommands/commands/table/doc-table-insert.command.ts 0.00% 123 Missing ⚠️
...r/src/components/docs/text-selection/rect-range.ts 0.00% 115 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 96 Missing ⚠️
.../components/docs/view-model/document-view-model.ts 0.00% 94 Missing ⚠️
.../components/docs/text-selection/selection-utils.ts 0.00% 93 Missing ⚠️
... and 78 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2814      +/-   ##
==========================================
- Coverage   27.16%   26.40%   -0.76%     
==========================================
  Files        1850     1868      +18     
  Lines       97516    99837    +2321     
  Branches    20838    21316     +478     
==========================================
- Hits        26486    26364     -122     
- Misses      71030    73473    +2443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs force-pushed the feat/doc-table-0 branch from 1a29f0e to 62d8fa9 Compare July 19, 2024 03:09
@Jocs Jocs force-pushed the feat/doc-table-0 branch 5 times, most recently from 42dcbd3 to 4fb67e6 Compare July 26, 2024 15:06
@Jocs Jocs force-pushed the feat/doc-table-0 branch 7 times, most recently from 09423b7 to 797d3bb Compare August 3, 2024 11:30
@Jocs Jocs force-pushed the feat/doc-table-0 branch from 39b01c0 to 6a39653 Compare August 5, 2024 09:02
@Jocs Jocs marked this pull request as ready for review August 5, 2024 09:51
@Jocs Jocs force-pushed the feat/doc-table-0 branch from 149f30b to f7a184b Compare August 6, 2024 07:21
@wzhudev
Copy link
Member

wzhudev commented Aug 6, 2024

/update-snapshots

@wzhudev
Copy link
Member

wzhudev commented Aug 6, 2024

update-snapshots

@wzhudev
Copy link
Member

wzhudev commented Aug 6, 2024

/update-snapshots

1 similar comment
@wzhudev
Copy link
Member

wzhudev commented Aug 6, 2024

/update-snapshots

@Jocs Jocs force-pushed the feat/doc-table-0 branch from e57c47f to b6cd20b Compare August 6, 2024 08:41
@Jocs Jocs merged commit b5efb0d into dev Aug 6, 2024
9 checks passed
@Jocs Jocs deleted the feat/doc-table-0 branch August 6, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] univer doc add insert tables
3 participants