Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): set bottom by default for vertical align #1929

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #1573

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 31.06%. Comparing base (6c2e1d3) to head (08358ca).

Files Patch % Lines
packages/sheets-ui/src/controllers/menu/menu.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1929   +/-   ##
=======================================
  Coverage   31.06%   31.06%           
=======================================
  Files        1207     1207           
  Lines       66176    66176           
  Branches    13994    13994           
=======================================
  Hits        20556    20556           
  Misses      45620    45620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer changed the title fix(sheet): set bottom for vertical align fix(sheet): set bottom by default for vertical align Apr 16, 2024
@zhaolixin7
Copy link

@DR-Univer 默认格式下字体还是底部工具栏还是顶部 image

@univer-bot
Copy link

univer-bot bot commented Apr 22, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@DR-Univer In the default format, the font is still at the bottom toolbar or at the topimage

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 22, 2024
@DR-Univer DR-Univer added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Apr 28, 2024
@wzhudev wzhudev merged commit 392f320 into dev Apr 29, 2024
9 checks passed
@wzhudev wzhudev deleted the fix-sheet-menu-vertical-bottom branch April 29, 2024 01:23
Jocs added a commit that referenced this pull request Aug 5, 2024
Jocs added a commit that referenced this pull request Aug 5, 2024
Jocs added a commit that referenced this pull request Aug 6, 2024
Jocs added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 工具栏底部对齐方式与单元格格式不符
4 participants