-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheets-ui): recover float-dom delete menu & focusing when zen-editor mount #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test resultsDetails 4 tests across 2 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3426 +/- ##
==========================================
- Coverage 30.56% 30.56% -0.01%
==========================================
Files 2155 2155
Lines 112726 112728 +2
Branches 24712 24713 +1
==========================================
Hits 34458 34458
- Misses 78268 78270 +2 ☔ View full report in Codecov by Sentry. |
weird94
changed the title
fix(sheets-hyper-link): zen editor popup should hide when selection change
fix(sheets-hyper-link): recover float-dom delete menu & focusing when zen-editor mount
Sep 13, 2024
Jocs
approved these changes
Sep 13, 2024
weird94
changed the title
fix(sheets-hyper-link): recover float-dom delete menu & focusing when zen-editor mount
fix(sheets-ui): recover float-dom delete menu & focusing when zen-editor mount
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx
Pull Request Checklist